Skip to content

Replaced TaggedType using QuoteContext #6950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2019
Merged

Replaced TaggedType using QuoteContext #6950

merged 1 commit into from
Jul 28, 2019

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki requested a review from liufengyun July 27, 2019 21:56
@nicolasstucki nicolasstucki self-assigned this Jul 27, 2019
liufengyun
liufengyun approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the test tests/pos/typetags.scala, otherwise, LGTM

@nicolasstucki nicolasstucki force-pushed the replaced-TaggedType-using-quoteContext branch from cbbcec0 to cc63ad2 Compare July 28, 2019 07:24
@nicolasstucki
Copy link
Contributor Author

Fixed tests/pos/typetags.scala

@nicolasstucki nicolasstucki marked this pull request as ready for review July 28, 2019 07:25
@nicolasstucki nicolasstucki force-pushed the replaced-TaggedType-using-quoteContext branch from cc63ad2 to 8123fea Compare July 28, 2019 09:05
@nicolasstucki nicolasstucki force-pushed the replaced-TaggedType-using-quoteContext branch from 8123fea to 3b1a53c Compare July 28, 2019 09:48
@nicolasstucki nicolasstucki merged commit a29e8a3 into scala:master Jul 28, 2019
@nicolasstucki nicolasstucki deleted the replaced-TaggedType-using-quoteContext branch July 28, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun